linux-kernel - Re: [PATCH 1/7] ASoC: neo1973_wm8753: Remove scenario management code.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 07 Feb 2011 18:01:41 +0100
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	Liam Girdwood <lrg@...mlogic.co.uk>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/7] ASoC: neo1973_wm8753: Remove scenario management
 code.

On 02/07/2011 12:42 PM, Mark Brown wrote:
> On Mon, Feb 07, 2011 at 12:04:17AM +0100, Lars-Peter Clausen wrote:
> 
>> +	snd_soc_dapm_disable_pin(codec, "Audio Out");
>> +	snd_soc_dapm_disable_pin(codec, "GSM Line Out");
>> +	snd_soc_dapm_disable_pin(codec, "GSM Line In");
>> +	snd_soc_dapm_disable_pin(codec, "Headset Mic");
>> +	snd_soc_dapm_disable_pin(codec, "Call Mic");
> 
> This will mean that it's impossible to enable most (if not all) of the
> audio paths in the system which probably isn't what you want.

I've seem to have overlooked to add DAPM_SWITCH_PIN controls for these pins, since it
has been done implicitly in the patch merging the gta01 and gta02 driver.

I'll resend a updated version.

- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/