linux-kernel - Re: [tip:perf/core] perf annotate: Fix annotate context lines regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 Feb 2011 14:15:37 -0200
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	Mike Galbraith <efault@....de>
Cc:	Ingo Molnar <mingo@...e.hu>, mingo@...hat.com, hpa@...or.com,
	paulus@...ba.org, eranian@...gle.com, linux-kernel@...r.kernel.org,
	tzanussi@...il.com, peterz@...radead.org, fweisbec@...il.com,
	tglx@...utronix.de, linux-tip-commits@...r.kernel.org
Subject: Re: [tip:perf/core] perf annotate: Fix annotate context lines
	regression

Em Thu, Feb 10, 2011 at 01:43:31PM +0100, Mike Galbraith escreveu:
> On Thu, 2011-02-10 at 13:15 +0100, Ingo Molnar wrote:
> > * Mike Galbraith <efault@....de> wrote:
> > 
> > > Initial impression: can I have a pony too? :)
> > > 
> > > I like this a lot, great for live rummaging.  One thing that would help with large 
> > > files maybe - a jump to next spot hotter than N%, but as is is quite nice.

It already does that if you use TAB/shift-TAB, first one goes to the
hottest line, next one to the 2nd place, etc, shift-TAB goes the other
direction.

There are some problems with that as on the first snapshot, just after
parsing the sources, all lines have zero hits, I plan to fix that doing
something like 'top' does, which is to wait a bit, say 2 seconds
collecting samples, then show the annotation centered on the hottest
line so far.

> > > I managed to lock it up once, but shiny new gizmos usually do hiccup.
> > 
> > The TUI locked up or the kernel? If it's the TUI then a gdb dump of the lockup would 
> > be nice.
> 
> TUI stopped responding to my key poking.  I'll see if it'll repeat
> (weekend).

Probably is something I already noticed and fixed, some mutex lock
inbalance, I'll repost it soon.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/