| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 14 Feb 2011 16:41:46 +0800 From: Eugene Teo <eugeneteo@...nel.org> To: Dan Rosenberg <drosenberg@...curity.com> Cc: aelder@....com, xfs-masters@....sgi.com, xfs@....sgi.com, security@...nel.org, linux-kernel@...r.kernel.org, stable@...nel.org, Eugene Teo <eugeneteo@...nel.org> Subject: Re: [Security] [PATCH] xfs: prevent leaking uninitialized stack memory in FSGEOMETRY_V1 On Thu, Feb 10, 2011 at 10:25 PM, Dan Rosenberg <drosenberg@...curity.com> wrote: > The FSGEOMETRY_V1 ioctl (and its compat equivalent) calls out to > xfs_fs_geometry() with a version number of 3. This code path does not > fill in the logsunit member of the passed xfs_fsop_geom_t, leading to > the leaking of four bytes of uninitialized stack data to potentially > unprivileged callers. Since all other members are filled in all code > paths and there are no padding bytes in this structure, it's safe to > avoid an expensive memset() in favor of just clearing this one field. > > Signed-off-by: Dan Rosenberg <drosenberg@...curity.com> There are three callers to xfs_fs_geometry() with version number 3 and 4. I don't see any for version number 2, so this looks fine. Reviewed-by: Eugene Teo <eugeneteo@...nel.org> Thanks, Eugene -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists