lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 18 Feb 2011 16:01:24 -0800 From: Andrew Morton <akpm@...ux-foundation.org> To: "Serge E. Hallyn" <serge@...lyn.com> Cc: LSM <linux-security-module@...r.kernel.org>, James Morris <jmorris@...ei.org>, Kees Cook <kees.cook@...onical.com>, containers@...ts.linux-foundation.org, kernel list <linux-kernel@...r.kernel.org>, "Eric W. Biederman" <ebiederm@...ssion.com>, Alexey Dobriyan <adobriyan@...il.com>, Michael Kerrisk <mtk.manpages@...il.com>, xemul@...allels.com, dhowells@...hat.com Subject: Re: [PATCH 6/9] user namespaces: convert all capable checks in kernel/sys.c On Thu, 17 Feb 2011 15:03:42 +0000 "Serge E. Hallyn" <serge@...lyn.com> wrote: > @@ -1177,8 +1189,11 @@ SYSCALL_DEFINE2(sethostname, char __user *, name, int, len) > int errno; > char tmp[__NEW_UTS_LEN]; > > - if (!ns_capable(current->nsproxy->uts_ns->user_ns, CAP_SYS_ADMIN)) > + if (!ns_capable(current->nsproxy->uts_ns->user_ns, CAP_SYS_ADMIN)) { > + printk(KERN_NOTICE "%s: did not have CAP_SYS_ADMIN\n", __func__); > return -EPERM; > + } > + printk(KERN_NOTICE "%s: did have CAP_SYS_ADMIN\n", __func__); > if (len < 0 || len > __NEW_UTS_LEN) > return -EINVAL; > down_write(&uts_sem); Left over debugging printks? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists