| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sun, 20 Feb 2011 17:45:14 -0500 From: Ilia Mirkin <imirkin@...m.mit.edu> To: drbd-dev@...ts.linbit.com Cc: linux-kernel@...r.kernel.org, Ilia Mirkin <imirkin@...m.mit.edu> Subject: [PATCH] lru_cache: Use correct type in sizeof for allocation This has no actual effect, since sizeof(struct hlist_head) == sizeof(struct hlist_head *), but it's still the wrong type to use. The semantic match that finds this problem: // <smpl> @@ type T; identifier x; @@ T *x; ... * x = kzalloc(... * sizeof(T*) * ..., ...); // </smpl> Signed-off-by: Ilia Mirkin <imirkin@...m.mit.edu> --- lib/lru_cache.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Note that in lc_reset, there is the line memset(lc->lc_slot, 0, sizeof(struct hlist_head) * lc->nr_elements); So this seems correct. But otherwise untested. diff --git a/lib/lru_cache.c b/lib/lru_cache.c index 270de9d..b312c8f 100644 --- a/lib/lru_cache.c +++ b/lib/lru_cache.c @@ -84,7 +84,7 @@ struct lru_cache *lc_create(const char *name, struct kmem_cache *cache, if (e_count > LC_MAX_ACTIVE) return NULL; - slot = kzalloc(e_count * sizeof(struct hlist_head*), GFP_KERNEL); + slot = kzalloc(e_count * sizeof(struct hlist_head), GFP_KERNEL); if (!slot) goto out_fail; element = kzalloc(e_count * sizeof(struct lc_element *), GFP_KERNEL); -- 1.7.3.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists