linux-kernel - RE: [PATCH] gpio: Fix wrong pointer type in pca953x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 22 Feb 2011 13:52:58 +0100
From:	"Eibach, Dirk" <Eibach@...ys.de>
To:	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] gpio: Fix wrong pointer type in pca953x

 

> >  	struct pca953x_platform_data *pdata;
> >  	struct device_node *node;
> > -	const uint16_t *val;
> > +	const u32 *val;
> >  
> 
> This should probably be signed?  We compare it against zero later on.
> 
>                 if (*val < 0)
>                         dev_warn(&client->dev,
>                                  "invalid gpio-base in device 
> tree\n");

Good catch.
of property values are generally unsigned. The whole check is bogus
here. Will supply updated patch later.

> regards,
> dan carpenter

Cheers
Dirk


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/