linux-kernel - Re: [PATCH 2/2] staging: vme: fix bug in vme_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 23 Feb 2011 15:24:43 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Martyn Welch <martyn.welch@...com>
Cc:	Manohar Vanga <manohar.vanga@...n.ch>, devel@...verdev.osuosl.org,
	gregkh@...e.de, cota@...ap.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] staging: vme: fix bug in vme_register_bridge

On Wed, Feb 23, 2011 at 09:44:42AM +0000, Martyn Welch wrote:
> On 23/02/11 09:26, Manohar Vanga wrote:
> > Fix a bug in vme_register_bridge that results in an infinite loop in
> > the event that device_register fails.

[snip]

> > +	/*
> > +	 * Ignore the failed device and unregister the rest.
> > +	 */
> > +	i--;
> >  	while (i > -1) {
> >  		dev = &bridge->dev[i];
> >  		device_unregister(dev);
> > +		i--;
> >  	}

Ah.  I see you fixed the bug already.  Good deal.  Btw, no need to add
comments for the obvious stuff.

You still aren't CCing the right list, devel@...verdev.osuosl.org.
It's not enough for Martyn to sent it to us, because by that point 
the patch has '> ' chars on every line.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/