linux-kernel - RE: [PATCH 08/09] ARM: s3c2440: gta02: Request usb pullup pin before using it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Feb 2011 15:16:40 +0900
From:	Kukjin Kim <kgene.kim@...sung.com>
To:	'Lars-Peter Clausen' <lars@...afoo.de>,
	'Ben Dooks' <ben-linux@...ff.org>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: RE: [PATCH 08/09] ARM: s3c2440: gta02: Request usb pullup pin before
 using it

Lars-Peter Clausen wrote:
> 
> Request the gpio pin used to control the usb pullup before using it to
avoid
> a
> runtime warning about an auto-requested gpio.
> 
> Signed-off-by: Lars-Peter Clausen <lars@...afoo.de>
> ---
>  arch/arm/mach-s3c2440/mach-gta02.c |   17 +++++++++++++++--
>  1 files changed, 15 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-s3c2440/mach-gta02.c
b/arch/arm/mach-s3c2440/mach-
> gta02.c
> index 1396639..94456fa 100644
> --- a/arch/arm/mach-s3c2440/mach-gta02.c
> +++ b/arch/arm/mach-s3c2440/mach-gta02.c
> @@ -451,11 +451,11 @@ static void gta02_udc_command(enum s3c2410_udc_cmd_e
> cmd)
>  	switch (cmd) {
>  	case S3C2410_UDC_P_ENABLE:
>  		pr_debug("%s S3C2410_UDC_P_ENABLE\n", __func__);
> -		gpio_direction_output(GTA02_GPIO_USB_PULLUP, 1);
> +		gpio_set_value(GTA02_GPIO_USB_PULLUP, 1);

How about following instead?
	gpio_request(GTA02_GPIO_USB_PULLUP, "USB_PULLUP");
	gpio_direction_output(GTA02_GPIO_USB_PULLUP, 1);
	gpio_free(GTA02_GPIO_USB_PULLUP);

>  		break;
>  	case S3C2410_UDC_P_DISABLE:
>  		pr_debug("%s S3C2410_UDC_P_DISABLE\n", __func__);
> -		gpio_direction_output(GTA02_GPIO_USB_PULLUP, 0);
> +		gpio_set_value(GTA02_GPIO_USB_PULLUP, 0);
>  		break;
>  	case S3C2410_UDC_P_RESET:
>  		pr_debug("%s S3C2410_UDC_P_RESET\n", __func__);
> @@ -572,11 +572,24 @@ static void gta02_poweroff(void)
>  	pcf50633_reg_set_bit_mask(gta02_pcf, PCF50633_REG_OOCSHDWN, 1, 1);
>  }
> 
> +static void gta02_request_gpios(void)
> +{
> +	int ret;
> +	ret = gpio_request_one(GTA02_GPIO_USB_PULLUP, GPIOF_OUT_INIT_LOW,
> +				"USB pullup");
> +	if (ret) {
> +		printk(KERN_ERR "Failed to request USB pullup gpio pin:
%d\n",
> +			ret);
> +	}
> +}
> +
>  static void __init gta02_machine_init(void)
>  {
>  	/* Set the panic callback to turn AUX LED on or off. */
>  	panic_blink = gta02_panic_blink;
> 
> +	gta02_request_gpios();
> +
>  	s3c_pm_init();
> 
>  #ifdef CONFIG_CHARGER_PCF50633
> --



Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@...sung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/