lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 1 Mar 2011 10:15:27 +0530 From: "TK, Pratheesh Gangadhar" <pratheesh@...com> To: "Hans J. Koch" <hjk@...sjkoch.de> CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "gregkh@...e.de" <gregkh@...e.de>, "tglx@...utronix.de" <tglx@...utronix.de>, "sshtylyov@...sta.com" <sshtylyov@...sta.com>, "arnd@...db.de" <arnd@...db.de>, "Chatterjee, Amit" <amit.chatterjee@...com>, "davinci-linux-open-source@...ux.davincidsp.com" <davinci-linux-open-source@...ux.davincidsp.com>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org> Subject: RE: [PATCH v6 1/1] PRUSS UIO driver support Hi, > -----Original Message----- > From: Hans J. Koch [mailto:hjk@...sjkoch.de] > Sent: Tuesday, March 01, 2011 2:57 AM > To: TK, Pratheesh Gangadhar > Cc: linux-kernel@...r.kernel.org; hjk@...sjkoch.de; gregkh@...e.de; > tglx@...utronix.de; sshtylyov@...sta.com; arnd@...db.de; Chatterjee, Amit; > davinci-linux-open-source@...ux.davincidsp.com; linux-arm- > kernel@...ts.infradead.org > Subject: Re: [PATCH v6 1/1] PRUSS UIO driver support > > On Tue, Mar 01, 2011 at 02:31:35AM +0530, Pratheesh Gangadhar wrote: > > + > > + /* Register PRUSS IRQ lines */ > > + p->irq = IRQ_DA8XX_EVTOUT0 + cnt; > > + p->handler = pruss_handler; > > + > > + ret = uio_register_device(&dev->dev, p); > > + > > + if (ret < 0) > > + goto out_free; > > + } > > + > > + spin_lock_init(&lock); > > That's too late. uio_register_device() enables the irq, and your spin_lock > is not ready at that time. This is ok in this context as "modprobe uio_pruss" is pre-requisite for running PRUSS firmware and without firmware running PRUSS won't generate interrupts. Actually PRUSS INTC is not setup till we start user application. Thanks, Pratheesh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists