linux-kernel - Re: [RFC v2 1/2] dynamic debug: add dynamic_hexdump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Feb 2011 21:25:38 -0800
From:	Joe Perches <joe@...ches.com>
To:	Bing Zhao <bzhao@...vell.com>
Cc:	linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org,
	"John W. Linville" <linville@...driver.com>,
	Johannes Berg <johannes@...solutions.net>,
	Amitkumar Karwar <akarwar@...vell.com>,
	Kiran Divekar <dkiran@...vell.com>,
	Frank Huang <frankh@...vell.com>
Subject: Re: [RFC v2 1/2] dynamic debug: add dynamic_hexdump_debug macro

On Mon, 2011-02-28 at 21:06 -0800, Bing Zhao wrote:
> dynamic_hexdump_debug(str, buf, len)

> diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
> +#define dynamic_hexdump_debug(str, buf, len)				\
> +do {									\
> +	static struct _ddebug descriptor				\
> +	__used								\
> +	__attribute__((section("__verbose"), aligned(8))) =		\
> +	{ KBUILD_MODNAME, __func__, __FILE__, str, __LINE__,		\
> +		_DPRINTK_FLAGS_DEFAULT };				\
> +	if (unlikely(descriptor.enabled)) {				\
> +		printk(KERN_DEBUG str);					\
> +		print_hex_dump_bytes("", DUMP_PREFIX_OFFSET, buf, len);	\

Perhaps
		print_hex_dump(str, DUMP_PREFIX_OFFSET, buf, len);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/