linux-kernel - Re: [PATCH] omap:iommu-added cache flushing operation for L2 cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 2 Mar 2011 13:58:58 +0200
From:	David Cohen <dacohen@...il.com>
To:	Fernando Guzman Lugo <fernando.lugo@...com>
Cc:	hiroshi.doyu@...ia.com, tony@...mide.com, linux@....linux.org.uk,
	linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, Ramesh Gupta <grgupta@...com>,
	Hari Kanigeri <h-kanigeri2@...com>
Subject: Re: [PATCH] omap:iommu-added cache flushing operation for L2 cache

Hi,

On Tue, Mar 1, 2011 at 9:46 PM, Fernando Guzman Lugo
<fernando.lugo@...com> wrote:
> From: Ramesh Gupta <grgupta@...com>

No patch body description at all?
Can we get at least something here?

Regards,

David

>
> Signed-off-by: Ramesh Gupta <grgupta@...com>
> Signed-off-by: Hari Kanigeri <h-kanigeri2@...com>
> ---
>  arch/arm/plat-omap/iommu.c |   22 ++++++++--------------
>  1 files changed, 8 insertions(+), 14 deletions(-)
>
> diff --git a/arch/arm/plat-omap/iommu.c b/arch/arm/plat-omap/iommu.c
> index e3eb038..aeb2c33 100644
> --- a/arch/arm/plat-omap/iommu.c
> +++ b/arch/arm/plat-omap/iommu.c
> @@ -471,22 +471,15 @@ EXPORT_SYMBOL_GPL(foreach_iommu_device);
>  */
>  static void flush_iopgd_range(u32 *first, u32 *last)
>  {
> -       /* FIXME: L2 cache should be taken care of if it exists */
> -       do {
> -               asm("mcr        p15, 0, %0, c7, c10, 1 @ flush_pgd"
> -                   : : "r" (first));
> -               first += L1_CACHE_BYTES / sizeof(*first);
> -       } while (first <= last);
> +       dmac_flush_range(first, last);
> +       outer_flush_range(virt_to_phys(first), virt_to_phys(last));
>  }
>
> +
>  static void flush_iopte_range(u32 *first, u32 *last)
>  {
> -       /* FIXME: L2 cache should be taken care of if it exists */
> -       do {
> -               asm("mcr        p15, 0, %0, c7, c10, 1 @ flush_pte"
> -                   : : "r" (first));
> -               first += L1_CACHE_BYTES / sizeof(*first);
> -       } while (first <= last);
> +       dmac_flush_range(first, last);
> +       outer_flush_range(virt_to_phys(first), virt_to_phys(last));
>  }
>
>  static void iopte_free(u32 *iopte)
> @@ -750,7 +743,7 @@ size_t iopgtable_clear_entry(struct iommu *obj, u32 da)
>  }
>  EXPORT_SYMBOL_GPL(iopgtable_clear_entry);
>
> -static void iopgtable_clear_entry_all(struct iommu *obj)
> +void iopgtable_clear_entry_all(struct iommu *obj)
>  {
>        int i;
>
> @@ -777,7 +770,7 @@ static void iopgtable_clear_entry_all(struct iommu *obj)
>
>        spin_unlock(&obj->page_table_lock);
>  }
> -
> +EXPORT_SYMBOL_GPL(iopgtable_clear_entry_all);
>  /*
>  *     Device IOMMU generic operations
>  */
> @@ -1068,6 +1061,7 @@ static void iopte_cachep_ctor(void *iopte)
>        clean_dcache_area(iopte, IOPTE_TABLE_SIZE);
>  }
>
> +
>  static int __init omap_iommu_init(void)
>  {
>        struct kmem_cache *p;
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/