linux-kernel - Re: [PATCH v4] hwmon: Add support for Texas Instruments ADS1015

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 2 Mar 2011 19:16:51 +0100
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Jean Delvare <khali@...ux-fr.org>
Cc:	Dirk Eibach <eibach@...ys.de>, linux-kernel@...r.kernel.org,
	guenter.roeck@...csson.com, lm-sensors@...sensors.org,
	rdunlap@...otime.net, linux-doc@...r.kernel.org
Subject: Re: [PATCH v4] hwmon: Add support for Texas Instruments ADS1015


> > +#ifdef CONFIG_OF
> > +	/* fallback on OF */
> > +	of_channels = of_get_property(np, "exported-channels",
> > +				      &of_channels_size);
> > +	if (of_channels && (of_channels_size == sizeof(*of_channels)))
> > +		return be32_to_cpup(of_channels);
> > +#endif
> 
> The be32 thing looks odd. I don't get the idea, but as I don't know
> much about devicetree, I'll trust you.

That's okay. The properties are be32 (coming from powerpc).

Still, there is a new property defined which _always_ needs

a) CCing devicetree-discuss (get_maintainer helps here)
b) Documentation in Documentation/devicetree/bindings

because it needs to be a lot more stable than platform_data.

(I already lost the original mail, so I sadly can't forward it)

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)