[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 3 Mar 2011 08:34:25 +0100 (CET)
From: Thomas Gleixner <tglx@...utronix.de>
To: Li Zefan <lizf@...fujitsu.com>
cc: "Kirill A. Shutsemov" <kirill@...temov.name>,
Paul Menage <menage@...gle.com>,
containers@...ts.linux-foundation.org,
jacob.jun.pan@...ux.intel.com,
Arjan van de Ven <arjan@...ux.intel.com>,
linux-kernel@...r.kernel.org, Matt Helsley <matthltc@...ibm.com>,
Andrew Morton <akpm@...ux-foundation.org>,
linux-api@...r.kernel.org
Subject: Re: [PATCH, v7] cgroups: introduce timer slack controller
On Thu, 3 Mar 2011, Li Zefan wrote:
> >> +unsigned long get_task_timer_slack(struct task_struct *tsk)
> >> +{
> >> + struct cgroup_subsys_state *css;
> >> + struct tslack_cgroup *tslack_cgroup;
> >> + unsigned long ret;
> >> +
> >> + rcu_read_lock();
> >
> > Did you just remove the odd comment or actually figure out why you
> > need rcu_read_lock() here ?
> >
>
> It's necessary to protect against task exiting or task moving between cgroups.
I know, though after the last review I wanted to make sure, that the
author understands it as well and not just removed the odd comment
just because I ranted about it :)
Thanks,
tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists