linux-kernel - Re: [PATCH 2/2] staging: keucr: use kernel byteorder functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 03 Mar 2011 07:58:59 +0000
From:	Jack Stone <jwjstone@...tmail.fm>
To:	Jonathan Neuschäfer <j.neuschaefer@....net>
CC:	Greg Kroah-Hartman <gregkh@...e.de>, Al Cho <acho@...ell.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] staging: keucr: use kernel byteorder functions

> @@ -455,10 +457,10 @@ int MS_LibProcessBootBlock(struct us_data *us, WORD PhyBlock, BYTE *PageData)
>  			}
>  
>  			idi = &((MemStickBootBlockCIS_IDI *)(PageBuffer + (EntryOffset % MS_BYTES_PER_PAGE)))->idi.idi;
> -			if (LittleEndianWORD(idi->wIDIgeneralConfiguration) != MS_IDI_GENERAL_CONF)
> +			if (le16_to_cpu(idi->wIDIgeneralConfiguration) != MS_IDI_GENERAL_CONF)
>  				goto exit;
>  
> -			us->MS_Lib.BytesPerSector = LittleEndianWORD(idi->wIDIbytesPerSector);
> +			us->MS_Lib.BytesPerSector = be16_to_cpu(idi->wIDIbytesPerSector);

Shouldn't this be le16_to_cpu?

>  			if (us->MS_Lib.BytesPerSector != MS_BYTES_PER_PAGE)
>  				goto exit;
>  		}

Thanks,

Jack
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/