linux-kernel - Re: [RFC] [PATCH 6/10] Generic Watchdog Timer Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 3 Mar 2011 11:44:18 +0100
From:	Wim Van Sebroeck <wim@...ana.be>
To:	Jamie Iles <jamie@...ieiles.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Linux Watchdog Mailing List <linux-watchdog@...r.kernel.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [RFC] [PATCH 6/10] Generic Watchdog Timer Driver

Hi Jamie,

> I don't fully understand why the module refcounting is done in the open 
> and release though.  If you moved it into the registration and 
> unregistration then doesn't that remove the need for WDOG_ORPHAN?

Hmm, nice suggestion. Will look into that.

> > diff --git a/drivers/watchdog/core/watchdog_core.c b/drivers/watchdog/core/watchdog_core.c
> > index 52bc520..d1a824e 100644
> > --- a/drivers/watchdog/core/watchdog_core.c
> > +++ b/drivers/watchdog/core/watchdog_core.c
> > @@ -60,6 +60,10 @@ int register_watchdogdevice(struct watchdog_device *wdd)
> >  	if (wdd == NULL || wdd->info == NULL || wdd->ops == NULL)
> >  		return -ENODATA;
> >  
> > +	/* Make sure that the owner of the watchdog operations exists */
> > +	if (wdd->ops->owner == NULL)
> > +		return -ENODATA;
> 
> Won't this be effectively NULL if the module is builtin?  It looks like 
> if it is builtin then THIS_MODULE would be defined as (struct module 
> *)0.

Same for this: I will look into this.

Thanks,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/