linux-kernel - Re: [Qualcomm PM8921 MFD 2/6] mfd: pm8xxx: Add irq support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 3 Mar 2011 15:22:42 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Abhijeet Dharmapurikar <adharmap@...eaurora.org>
Cc:	davidb@...eaurora.org, "David S. Miller" <davem@...emloft.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Bryan Huntsman <bryanh@...eaurora.org>,
	Daniel Walker <dwalker@...o99.com>,
	David Collins <collinsd@...eaurora.org>,
	Grant Likely <grant.likely@...retlab.ca>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Joe Perches <joe@...ches.com>,
	Russell King <linux@....linux.org.uk>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Stepan Moskovchenko <stepanm@...eaurora.org>,
	Linus Walleij <linux.walleij@...rricsson.com>,
	linux-arm-kernel@...ts.infradead.org,
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [Qualcomm PM8921 MFD 2/6] mfd: pm8xxx: Add irq support

On Wed, Mar 02, 2011 at 08:38:03PM -0800, Abhijeet Dharmapurikar wrote:
> Mark Brown wrote:

> >Is it really useful to register a struct device purely for the interrupt
> >controller?  I'd have expected this to be core functionality of the
> >device.  The fact that you need to store the device at all is a bit odd
> >too as you're using the MFD API.

> This design is slightly different from other MFD drivers.
> I separated the interrupt from the core because the interrupt
> implementation for different Qualcomm pmics remains the same. On
> 8660 FFA boards for example, we have two pmic chips that have the
> same interrupt subdevice implementation (the number of interrupts
> managed by each is different). I didn't want to duplicate the exact
> code in the core driver - hence a separate interrupt driver.

Could you deal with this with a library instead?

> With that in mind, the driver has following functions
> pm8xxxx_read_root
> pm8xxxx_read_master
> pm8xxxx_read_block

> Do you still think I should change the name?

I'd suggest adding an _irq in there.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/