linux-kernel - Re: [Keyrings] [PATCH] KEYS: Add an RCU payload dereference macro

Open Source and information security mailing list archives

Date:	Thu, 03 Mar 2011 16:23:39 -0500
From:	Mimi Zohar <zohar@...ux.vnet.ibm.com>
To:	David Howells <dhowells@...hat.com>
Cc:	linux-security-module@...r.kernel.org, keyrings@...ux-nfs.org,
	linux-kernel@...r.kernel.org
Subject: Re: [Keyrings] [PATCH] KEYS: Add an RCU payload dereference macro

On Thu, 2011-03-03 at 17:32 +0000, David Howells wrote:
> Add an RCU payload dereference macro as this seems to be a common piece of code
> amongst key types that use RCU referenced payloads.
> 
> Signed-off-by: David Howells <dhowells@...hat.com>

Yes, a lot cleaner. thanks!

Signed-of-by: Mimi Zohar <zohar@...ibm.com>

> ---
> 
>  include/linux/key.h          |    4 ++++
>  security/keys/encrypted.c    |    3 +--
>  security/keys/trusted.c      |    3 +--
>  security/keys/user_defined.c |    3 +--
>  4 files changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/include/linux/key.h b/include/linux/key.h
> index 3db0adc..a6b1edc 100644
> --- a/include/linux/key.h
> +++ b/include/linux/key.h
> @@ -275,6 +275,10 @@ static inline key_serial_t key_serial(struct key *key)
>  	return key ? key->serial : 0;
>  }
> 
> +#define rcu_dereference_key(KEY)					\
> +	(rcu_dereference_protected((KEY)->payload.rcudata,		\
> +				   rwsem_is_locked(&((struct key *)(KEY))->sem)))
> +
>  #ifdef CONFIG_SYSCTL
>  extern ctl_table key_sysctls[];
>  #endif
> diff --git a/security/keys/encrypted.c b/security/keys/encrypted.c
> index 9e7e4ce..69907a5 100644
> --- a/security/keys/encrypted.c
> +++ b/security/keys/encrypted.c
> @@ -765,8 +765,7 @@ static long encrypted_read(const struct key *key, char __user *buffer,
>  	size_t asciiblob_len;
>  	int ret;
> 
> -	epayload = rcu_dereference_protected(key->payload.data,
> -				  rwsem_is_locked(&((struct key *)key)->sem));
> +	epayload = rcu_dereference_key(key);
> 
>  	/* returns the hex encoded iv, encrypted-data, and hmac as ascii */
>  	asciiblob_len = epayload->datablob_len + ivsize + 1
> diff --git a/security/keys/trusted.c b/security/keys/trusted.c
> index 83fc92e..c99b936 100644
> --- a/security/keys/trusted.c
> +++ b/security/keys/trusted.c
> @@ -1076,8 +1076,7 @@ static long trusted_read(const struct key *key, char __user *buffer,
>  	char *bufp;
>  	int i;
> 
> -	p = rcu_dereference_protected(key->payload.data,
> -			rwsem_is_locked(&((struct key *)key)->sem));
> +	p = rcu_dereference_key(key);
>  	if (!p)
>  		return -EINVAL;
>  	if (!buffer || buflen <= 0)
> diff --git a/security/keys/user_defined.c b/security/keys/user_defined.c
> index 02807fb..c6ca866 100644
> --- a/security/keys/user_defined.c
> +++ b/security/keys/user_defined.c
> @@ -184,8 +184,7 @@ long user_read(const struct key *key, char __user *buffer, size_t buflen)
>  	struct user_key_payload *upayload;
>  	long ret;
> 
> -	upayload = rcu_dereference_protected(
> -		key->payload.data, rwsem_is_locked(&((struct key *)key)->sem));
> +	upayload = rcu_dereference_key(key);
>  	ret = upayload->datalen;
> 
>  	/* we can return the data as is */
> 
> _______________________________________________
> Keyrings mailing list
> Keyrings@...ux-nfs.org
> To change your subscription to this list, please see http://linux-nfs.org/cgi-bin/mailman/listinfo/keyrings

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives