linux-kernel - Re: [patch] x86, mm: Clean up initmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 04 Mar 2011 01:10:22 +0300
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	David Rientjes <rientjes@...gle.com>
CC:	Yinghai Lu <yinghai@...nel.org>, Tejun Heo <tj@...nel.org>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, tglx@...utronix.de,
	brgerst@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [patch] x86, mm: Clean up initmem_init

On 03/04/2011 01:05 AM, David Rientjes wrote:
> On Thu, 3 Mar 2011, Yinghai Lu wrote:
> 
>> he want
>>
>>> +#ifdef CONFIG_ACPI_NUMA
>>>>> +		ret = numa_init(x86_acpi_numa_init);
>>>>> +		if (!ret)
>>>>> +			return;
>>>>> +#endif
>>>>> +#ifdef CONFIG_AMD_NUMA
>>>>> +		ret = numa_init(amd_numa_init);
>>>>> +		if (!ret)
>>>>> +			return;
>>>>> +#endif
>>
>> to be replaced by:
>>
>>> +#ifdef CONFIG_ACPI_NUMA
>>>>> +		if (!numa_init(x86_acpi_numa_init))
>>>>> +			return;
>>>>> +#endif
>>>>> +#ifdef CONFIG_AMD_NUMA
>>>>> +		if (!numa_init(amd_numa_init))
>>>>> +			return;
>>>>> +#endif
> 
> It's a matter of style and I think it's up to Ingo what he'd prefer to 
> see.

i'm fine with either, just though it would shrink the code a bit (since there
is no need to track var witch i guess will be eliminated by gcc anyway).

nb: am i only the one who obtain bounce from shaohui.zheng@...el.com (so i'd to remove
him from cc'ing)?
-- 
    Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/