linux-kernel - Re: [PATCH 7/7] x86: fix section of a disable_apic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 04 Mar 2011 10:06:42 +0100
From:	Henrik Kretzschmar <henne@...htwindheim.de>
To:	Cyrill Gorcunov <gorcunov@...il.com>
CC:	mingo@...e.hu, tglx@...utronix.de, hpa@...or.com, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/7] x86: fix section of a disable_apic_timer

Am 03.03.2011 22:18, schrieb Cyrill Gorcunov:
> On 03/03/2011 11:05 PM, Henrik Kretzschmar wrote:
>> This variable placed better into section .init.data,
>> since its only accessed by __init code.
>>
>> Signed-off-by: Henrik Kretzschmar <henne@...htwindheim.de>
>> ---
>>  arch/x86/kernel/apic/apic.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
>> index 64efb2d..dab58b6 100644
>> --- a/arch/x86/kernel/apic/apic.c
>> +++ b/arch/x86/kernel/apic/apic.c
>> @@ -163,7 +163,7 @@ early_param("nox2apic", setup_nox2apic);
>>  unsigned long mp_lapic_addr;
>>  int disable_apic;
>>  /* Disable local APIC timer from the kernel commandline or via dmi quirk */
>> -static int disable_apic_timer __cpuinitdata;
>> +static int disable_apic_timer __initdata = 0;
>>  /* Local APIC timer works in C2 */
>>  int local_apic_timer_c2_ok;
>>  EXPORT_SYMBOL_GPL(local_apic_timer_c2_ok);
> 
> Good to me, though I don't get why we need 0 here.
> 

I wanted to help gcc, but some tests showed me that gcc is much cleverer than I thought.
So I verified that you are right and I'll change that gladly.





--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/