linux-kernel - Re: [PATCH 0/3] ARM: Add Scorpion/ScorpionMP support to perf and Oprofile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 04 Mar 2011 14:42:29 -0800
From:	Bryan Huntsman <bryanh@...eaurora.org>
To:	Sheetal Sahasrabudhe <sheetals@...eaurora.org>
CC:	linux-arm-kernel@...ts.infradead.org, will.deacon@....com,
	jamie.iles@...ochip.com, jean.pihet@...oldbits.com,
	robert.richter@....com, dwalker@...o99.com, davidb@...eaurora.org,
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] ARM: Add Scorpion/ScorpionMP support to perf and
 Oprofile

On 03/04/2011 02:09 PM, Sheetal Sahasrabudhe wrote:
> This patchset contains the following features:
> It adds support for Qualcomm Scorpion and ScorpionMP processors to perfevents
> and Oprofile.
> It adds PMU support for Scorpion and ScorpionMP.
> It also updates PMU IRQ identifiers for various Scorpion and ScorpionMP targets.
> 
> Sheetal Sahasrabudhe (3):
>   msm: Add support for Scorpion and ScorpionMP PMU
>   [ARM] perfevents: Add support for Scorpion performance monitors
>   [ARM] Oprofile: Add Qualcomm Scorpion and ScorpionMP CPU type
> 
>  arch/arm/include/asm/perf_event.h          |    2 +
>  arch/arm/kernel/perf_event.c               |   11 +
>  arch/arm/kernel/perf_event_qc.c            |  677 ++++++++++++++++++++++++++++
>  arch/arm/mach-msm/Makefile                 |    2 +
>  arch/arm/mach-msm/include/mach/irqs-7x30.h |    2 +-
>  arch/arm/mach-msm/include/mach/irqs-8960.h |    2 +-
>  arch/arm/mach-msm/include/mach/irqs-8x50.h |    2 +-
>  arch/arm/mach-msm/include/mach/irqs-8x60.h |    2 +-
>  arch/arm/mach-msm/pmu.c                    |   36 ++
>  arch/arm/oprofile/common.c                 |    4 +
>  10 files changed, 736 insertions(+), 4 deletions(-)
>  create mode 100644 arch/arm/kernel/perf_event_qc.c
>  create mode 100644 arch/arm/mach-msm/pmu.c
> 

Some minor comments from a quick review:
- you're using multi-line commenting style for single line comments
- see Documentation/CodingStyle, Chapter 8, for preferred multi-line
commenting style
- 'mv perf_event_qc.c perf_event_msm.c'?

- Bryan

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/