linux-kernel - Re: [PATCH 05/10] block: remove per-queue plugging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 9 Mar 2011 08:25:36 +0100
From:	Jens Axboe <jaxboe@...ionio.com>
To:	Jeff Moyer <jmoyer@...hat.com>
CC:	Mike Snitzer <snitzer@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"hch@...radead.org" <hch@...radead.org>
Subject: Re: [PATCH 05/10] block: remove per-queue plugging

On 2011-03-08 22:36, Jeff Moyer wrote:
> Jens Axboe <jaxboe@...ionio.com> writes:
> 
>> On 2011-03-08 21:21, Mike Snitzer wrote:
>>> On Tue, Mar 08 2011 at  7:16am -0500,
>>> Jens Axboe <jaxboe@...ionio.com> wrote:
>>>
>>>> On 2011-03-03 23:13, Mike Snitzer wrote:
>>>>> I'm now hitting a lockdep issue, while running a 'for-2.6.39/stack-plug'
>>>>> kernel, when I try an fsync heavy workload to a request-based mpath
>>>>> device (the kernel ultimately goes down in flames, I've yet to look at
>>>>> the crashdump I took)
>>>>
>>>> Mike, can you re-run with the current stack-plug branch? I've fixed the
>>>> !CONFIG_BLOCK and rebase issues, and also added a change for this flush
>>>> on schedule event. It's run outside of the runqueue lock now, so
>>>> hopefully that should solve this one.
>>>
>>> Works for me, thanks.
>>
>> Super, thanks! Out of curiousity, did you use dm/md?
> 
> mm/memory-failure.c: In function 'hwpoison_user_mappings':
> mm/memory-failure.c:948: error: implicit declaration of function 'lock_page_nosync'
> 
> You missed a conversion of lock_page_nosync -> lock_page.

Thanks Jeff, I guess I should run a full modconfig/yesconfig build again
just to check that everyone is still uptodate.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/