linux-kernel - Re: [PATCH -v5] kbuild: Add extra gcc checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 Mar 2011 11:25:11 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Michal Marek <mmarek@...e.cz>
Cc:	Ingo Molnar <mingo@...e.hu>, Borislav Petkov <bp@...en8.de>,
	Arnd Bergmann <arnd@...db.de>, torvalds@...ux-foundation.org,
	x86@...nel.org, linux-kernel@...r.kernel.org,
	linux-kbuild@...r.kernel.org, bp@...64.org
Subject: Re: [PATCH -v5] kbuild: Add extra gcc checks

> One way without extending the current rules could be:
> 
> ifdef CONFIG_CC_WERROR
> Werror := -Werror
> endif
> 
> CFLAGS_sched.o := $(Werror)
> CFLAGS_another.o := $(Werror)
> 
> What do you think?

We could extend kbuild to support something like this:

    ccflags-<filename>-y := -Werror

Sample:

    ccflags-sched.o-$(CONFIG_WERROR) := -Werror

The above is a nice counterpart to the existing ccflags-y.
And we could then deprecate CLFAGS_<filename> as we have today.

To remove options we could use:

ccflags-<filename>-remove-y := -pg

This is a replacement of the undocumented CFLAGS_REMOVE_<filename> variant.

Today:
    ifdef CONFIG_FUNCTION_TRACER
    CFLAGS_REMOVE_lockdep.o = -pg
    endif

Could be replaced with:

   ccflags-lockdep.o-remove-$(CONFIG_FUNCTION_TRACER) := -pg

The ifdef often cover more than one file so we save less lines in
reality than the example says.


All looks rather trivial to implement.
But it is maybe a bit too cryptic?

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/