linux-kernel - Re: About GPIO interrupt function with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 Mar 2011 21:22:15 +0530
From:	Rabin Vincent <rabin@....in>
To:	Tomoya MORINAGA <tomoya-linux@....okisemi.com>
Cc:	Grant Likely <grant.likely@...retlab.ca>,
	linux-kernel@...r.kernel.org,
	"Ewe, Kok Howg" <kok.howg.ewe@...el.com>,
	"Lai, Mee Sim" <mee.sim.lai@...el.com>,
	Toshiharu Okada <toshiharu-linux@....okisemi.com>
Subject: Re: About GPIO interrupt function with sysfs

On Wed, Mar 2, 2011 at 12:08, Tomoya MORINAGA
<tomoya-linux@....okisemi.com> wrote:
> Seeing gpio_to_irq@...h/x86/include/asm/gpio.h, like below.
>
> static inline int gpio_to_irq(unsigned int gpio)
> {
>        return -ENOSYS;
> }

That's not what is in latest mainline:

commit 718c45bd1aa80c4e23a0ee204c973e3014e94708
Author: Alek Du <alek.du@...el.com>
Date:   Tue Jan 11 10:55:32 2011 +0000

    x86/gpio: Implement x86 gpio_to_irq convert function

    We need this for x86 MID platforms where GPIO interrupts are
    used. No special magic is needed so the default 1:1 behaviour
    will do nicely.

    Signed-off-by: Alek Du <alek.du@...el.com>
    Signed-off-by: Jacob Pan <jacob.jun.pan@...el.com>
    Signed-off-by: Alan Cox <alan@...ux.intel.com>
    LKML-Reference: <20110111105439.24448.69863.stgit@....linux.org.uk>
    Signed-off-by: Ingo Molnar <mingo@...e.hu>

diff --git a/arch/x86/include/asm/gpio.h b/arch/x86/include/asm/gpio.h
index 49dbfdf..91d915a 100644
--- a/arch/x86/include/asm/gpio.h
+++ b/arch/x86/include/asm/gpio.h
@@ -38,12 +38,9 @@ static inline int gpio_cansleep(unsigned int gpio)
 	return __gpio_cansleep(gpio);
 }

-/*
- * Not implemented, yet.
- */
 static inline int gpio_to_irq(unsigned int gpio)
 {
-	return -ENOSYS;
+	return __gpio_to_irq(gpio);
 }

 static inline int irq_to_gpio(unsigned int irq)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/