linux-kernel - Re: [PATCH] can : TI_HECC : Unintialized variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 10 Mar 2011 18:07:32 +0100
From:	Wolfgang Grandegger <wg@...ndegger.com>
To:	Abhilash K V <abhilash.kv@...com>
CC:	socketcan-core@...ts.berlios.de, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
	Vaibhav Hiremath <hvaibhav@...com>
Subject: Re: [PATCH] can : TI_HECC : Unintialized variables

On 03/10/2011 05:21 PM, Abhilash K V wrote:
> 1. In ti_hecc_xmit(), "data" is not initialized, causing
>    undesirable effects like setting the RTR field for every
>    transmit.

Does it need to be initialized to "data = cf->can_dlc"? If yes, please
correct the message, if not ...

> 2. In ti_hecc_probe(), the spinlock  priv->mbx_lock is not
>    inited, causing a spinlock lockup BUG.
> 
> Signed-off-by: Vaibhav Hiremath <hvaibhav@...com>
> Acked-by: Anant Gole <anantgole@...com>
> Signed-off-by: Abhilash K V <abhilash.kv@...com>
> ---
>  drivers/net/can/ti_hecc.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/can/ti_hecc.c b/drivers/net/can/ti_hecc.c
> index 4d07f1e..73c6025 100644
> --- a/drivers/net/can/ti_hecc.c
> +++ b/drivers/net/can/ti_hecc.c
> @@ -503,6 +503,7 @@ static netdev_tx_t ti_hecc_xmit(struct sk_buff *skb, struct net_device *ndev)
>  	spin_unlock_irqrestore(&priv->mbx_lock, flags);
>  
>  	/* Prepare mailbox for transmission */
> +	data = cf->can_dlc;
>  	if (cf->can_id & CAN_RTR_FLAG) /* Remote transmission request */
>  		data |= HECC_CANMCF_RTR;
>  	data |= get_tx_head_prio(priv) << 8;

... using the following expressions looks more reasonable:

  	data = get_tx_head_prio(priv) << 8;
 	if (cf->can_id & CAN_RTR_FLAG) /* Remote transmission request */
 		data |= HECC_CANMCF_RTR;
	
Wolfgang.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/