linux-kernel - Re: [PATCHv2-RESEND] mcp23s08: support mcp23s17 variant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 12 Mar 2011 01:29:06 -0700
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Peter Korsgaard <jacmet@...site.dk>
Cc:	dbrownell@...rs.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2-RESEND] mcp23s08: support mcp23s17 variant

On Wed, Mar 09, 2011 at 05:56:30PM +0100, Peter Korsgaard wrote:
> mpc23s17 is very similar to the mcp23s08, except that registers are 16bit
> wide, so extend the interface to work with both variants.
> 
> The s17 variant also has an additional address pin, so adjust platform
> data structure to support up to 8 devices per SPI chipselect.
> 
> Signed-off-by: Peter Korsgaard <jacmet@...site.dk>

Merged, thanks.

g.

> ---
> Resend without any changes since v2 on Feb 15th.
> 
> Changes since v1:
> - Add mcp23s08_ops callbacks for 8 and 16 bit instead of handling both
>   in the same accessor function as requested by Grant.
> - Don't use a temporary buffer for 8bit version of read_regs -
>   Stack addresses are not DMA safe.
> 
>  drivers/gpio/Kconfig         |    6 +-
>  drivers/gpio/mcp23s08.c      |  191 +++++++++++++++++++++++++++++++-----------
>  include/linux/spi/mcp23s08.h |   15 ++--
>  3 files changed, 155 insertions(+), 57 deletions(-)
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/