linux-kernel - Re: [RFC PATCH 3/4] PLATFORM: Introduce async platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 13 Mar 2011 16:26:12 -0700
From:	Greg KH <greg@...ah.com>
To:	andy.green@...aro.org
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, patches@...aro.org
Subject: Re: [RFC PATCH 3/4] PLATFORM: Introduce async platform_data attach
 api

On Sun, Mar 13, 2011 at 06:13:07PM +0000, Andy Green wrote:
> On 03/13/2011 05:48 PM, Somebody in the thread at some point said:
> >On Sun, Mar 13, 2011 at 05:13:31PM +0000, Andy Green wrote:
> >>So when there's a bit more of Device Tree in evidence, are you going
> >>to accept Device-tree based patches in usbnet etc along these lines,
> >>or does that trigger the "do it in userspace" response, in which
> >>case we are both wasting each others' time continuing to discuss
> >>this at all?
> >
> >As mentioned numerous times before, network naming stuff happens in
> >userspace, not in the kernel, so no matter what infrastructure is added,
> 
> The naming of that network interface happens in smsc95xx, in kernel:
> it uses a dodgy heuristic to choose between usb%d eth%d and others
> and gets it wrong in this case due to stuff outside its view.
> There's nothing golden and wonderful about that which needs
> protecting from outside hints.

Then why not always do this in userspace correctly?  It's the _exact_
same problem that the server companies have in naming their network
devices in a proper manner (i.e. the port with the 0 label on it wants
to always be eth0).  We have the tools today to solve this issue, in a
consistant and proper manner, please use them.

> >insisting on naming the network device 'eth0' is not going to happen
> >within the kernel.  Please use the tools we have today to do this with
> >no kernel changes.
> >
> >As for other changes, it all depends on what you need to accomplish,
> >right?  Those will be gladly reviewed on a case-by-case basis.
> 
> The immediate thing I would have liked to accomplish is to help
> smsc95xx make the right decision about naming and to use the MAC
> address in platform_data.  It seemed this was a general issue
> though, so I generalized how it was done.  But I don't have examples
> on my desk of boards with soldered-on USB other than smsc95xx
> Ethernet bridge.
> 
> At least, I am grateful we get down to brass tacks now and you
> clearly reject allowing the driver to take guidance to act more
> appropriately for its environment in the first place.  Therefore,
> this won't get fixed by Device Tree either.

I beg to differ.  I'm stating that USB drivers can not use their
numbering to do anything with them as that is never going to be
deterministic.

That's all.  You seem to disagree with this.

> So, we don't need to discuss this any further: thanks again for your
> time.

Ok, so does this mean that you are convinced that I am correct here, or
are just giving up and going to keep your patches outside of the kernel,
or something else?

confused,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/