linux-kernel - Re: [PATCH 0/7] genksyms: Track changes to enum constant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 13 Mar 2011 08:19:02 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Michal Marek <mmarek@...e.cz>
Cc:	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/7] genksyms: Track changes to enum constant

Hi Michal.

Patch serie looks good.
You can add my ack to all of them if you do a second round.


On Sun, Mar 13, 2011 at 07:30:18AM +0100, Michal Marek wrote:
> This series makes genksyms remember the values of enum constants and use them
> during symbol expansion. This makes sure that patches like
> 
> | enum e {
> |  	E1,
> | 	E2,
> |+	E3,
> | 	E_MAX
> | };
> |
> | struct s {
> | 	int a[E_MAX];
> | }
> |
> | int f(struct s *s) { ... }
> | EXPORT_SYMBOL(f)
> 
> change the checksum of the exported symbol. Previously, it would just use the
> string "E_MAX" in the calculation and the change would go unnoticed. The main
> part is in patches 6/7 and 7/7, the rest are cleanups and preparatory patches.

This nice explanation would be good to include in the changelog
of 7/8 so "git log" give a better intro to the changes.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/