| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 14 Mar 2011 11:02:05 +0100 From: Heiko Carstens <heiko.carstens@...ibm.com> To: chenliu@...et.uwaterloo.ca Cc: schwidefsky@...ibm.com, linux390@...ibm.com, cotte@...ibm.com, linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH]early: Fix possible overlapping data buffer On Fri, Mar 11, 2011 at 11:04:42AM -0500, chenliu@...et.uwaterloo.ca wrote: > Thanks Heiko. I've followed your advice to give a new patch here. > --------------------------------- > > This patch fixed bugzilla #12965: > https://bugzilla.kernel.org/show_bug.cgi?id=12965 > > The original code contains some inproper use of sprintf > function where a buffer is used both as input string > as well as output string. It should remember the written > bytes in the previous and use that as the offset for > later writing. Also replace sprintf with snprintf. > > Signed-off-by: Chen Liu <chenliunju@...il.com> Hi Chen, I still want a patch where the From: and Signed-off-by: lines are identical. Otherwise I won't take the patch. Also you didn't answer my other question: did you actually test that after your change the code still works? If not, then I would have to do that. The patch looks ok so far (besides two lines that could be removed). Thanks, Heiko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists