linux-kernel - Re: [PATCH v3 7/7] tty: add pruss SUART driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Mar 2011 12:53:47 +0530
From:	"Subhasish Ghosh" <subhasish@...tralsolutions.com>
To:	"Randy Dunlap" <randy.dunlap@...cle.com>
Cc:	<davinci-linux-open-source@...ux.davincidsp.com>,
	<linux-arm-kernel@...ts.infradead.org>, <m-watkins@...com>,
	<nsekhar@...com>, <sachi@...tralsolutions.com>,
	"maintainer:TTY LAYER <gregkh@...e.de>, commit_signer:2/4=50%,
	commit_signer:1/2=50%" <Greg.Kroah-Hartman@...inet15.oracle.com>,
	"Andrew Morton \(commit_signer:1/4=25%\)" <akpm@...ux-foundation.org>,
	"Randy Dunlap \(commit_signer:1/4=25%\)" <randy.dunlap@...cle.com>,
	"open list" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 7/7] tty: add pruss SUART driver

Hello,

Thank you for your comments.
Would really appreciate more comments and ways to fix this patch and bring 
it
up to Linux Standards.
If I have missed something/misunderstood then please let me know.


>> +config SERIAL_PRUSS_SUART
>> + depends on ARCH_DAVINCI && ARCH_DAVINCI_DA850
>> + select SERIAL_CORE
>> + tristate "PRUSS based SoftUART emulation on DA8XX"
>> + ---help---
>> + This driver emulates upto eight different UARTs on the PRUSS.
>
>                      up to
>
SG -- Ok Will do.


>> + You may modify the NR_SUARTS macro in the driver to emulate
>> + less number of UARTS as per your requirement.
>> + If not sure, mark N
>
>              mark N.
>
SG -- Ok Will do.


>> +    Enter the McASP number to use with SUART (0, 1 or 2).
>> + You will need to recompile the kernel if this is changed.
>
> The 2 help text lines should be indented the same.
>
SG - Ok will do.
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/