linux-kernel - Re: [PATCH 26/36] perf,rcu: convert call_rcu(free_ctx) to kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 18 Mar 2011 10:35:21 +0100
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Lai Jiangshan <laijs@...fujitsu.com>
Cc:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Ingo Molnar <mingo@...e.hu>, Paul Mackerras <paulus@...ba.org>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 26/36] perf,rcu: convert call_rcu(free_ctx) to
 kfree_rcu()

On Fri, 2011-03-18 at 12:07 +0800, Lai Jiangshan wrote:
> 
> The rcu callback free_ctx() just calls a kfree(),
> so we use kfree_rcu() instead of the call_rcu(free_ctx).
> 
> Signed-off-by: Lai Jiangshan <laijs@...fujitsu.com>

Acked-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>

Please take them through whatever tree adds kfree_rcu() as that doesn't
seem to be part of any tree near me.

> ---
>  kernel/perf_event.c |   10 +---------
>  1 files changed, 1 insertions(+), 9 deletions(-)
> 
> diff --git a/kernel/perf_event.c b/kernel/perf_event.c
> index ed253aa..b0581bd 100644
> --- a/kernel/perf_event.c
> +++ b/kernel/perf_event.c
> @@ -584,14 +584,6 @@ static void get_ctx(struct perf_event_context *ctx)
>  	WARN_ON(!atomic_inc_not_zero(&ctx->refcount));
>  }
>  
> -static void free_ctx(struct rcu_head *head)
> -{
> -	struct perf_event_context *ctx;
> -
> -	ctx = container_of(head, struct perf_event_context, rcu_head);
> -	kfree(ctx);
> -}
> -
>  static void put_ctx(struct perf_event_context *ctx)
>  {
>  	if (atomic_dec_and_test(&ctx->refcount)) {
> @@ -599,7 +591,7 @@ static void put_ctx(struct perf_event_context *ctx)
>  			put_ctx(ctx->parent_ctx);
>  		if (ctx->task)
>  			put_task_struct(ctx->task);
> -		call_rcu(&ctx->rcu_head, free_ctx);
> +		kfree_rcu(ctx, rcu_head);
>  	}
>  }
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/