linux-kernel - RE: [PATCHv4 2/3] ARM: mx51: Implement code to allow mx51 to enter WFI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 18 Mar 2011 15:34:51 +0000
From:	Nguyen Dinh-R00091 <R00091@...escale.com>
To:	Fabio Estevam <festevam@...il.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	"s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
	"u.kleine-koenig@...gutronix.de" <u.kleine-koenig@...gutronix.de>,
	"arnaud.patard@...-net.org" <arnaud.patard@...-net.org>,
	Vaidyanathan Ranjani-RA5478 <RA5478@...escale.com>,
	Zhang Lily-R58066 <R58066@...escale.com>
Subject: RE: [PATCHv4 2/3] ARM: mx51: Implement code to allow mx51 to enter
 WFI

Hi Fabio,

>-----Original Message-----
>From: Fabio Estevam [mailto:festevam@...il.com]
>Sent: Friday, March 18, 2011 10:31 AM
>To: Nguyen Dinh-R00091
>Cc: linux-kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
>linux@....linux.org.uk; s.hauer@...gutronix.de; u.kleine-
>koenig@...gutronix.de; arnaud.patard@...-net.org; Vaidyanathan Ranjani-
>RA5478; Zhang Lily-R58066
>Subject: Re: [PATCHv4 2/3] ARM: mx51: Implement code to allow mx51 to
>enter WFI
>
>Hi Dinh,
>
>On Fri, Mar 18, 2011 at 12:21 PM,  <Dinh.Nguyen@...escale.com> wrote:
>...
>> +       /* Enable NEON SRPG for all but MX50TO1.0. */
>> +       if (cpu_is_mx51() || cpu_is_mx53())
>> +               __raw_writel(arm_srpgcr, MXC_SRPG_NEON_SRPGCR);
>
>The comment says that NEON SRPG should not be enabled for MX50 TO1.0,
>but your code does not check the MX50 silicon revision.

There is no mechanism for checking MX50 Revisions yet. I'll work on adding the MX50 revision check.

Dinh
>
>Regards,
>
>Fabio Estevam