lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 18 Mar 2011 18:43:24 +0200
From:	<Waldemar.Rymarkiewicz@...to.com>
To:	<w.sang@...gutronix.de>
CC:	<linux-i2c@...r.kernel.org>, <arnd@...db.de>,
	<sameo@...ux.intel.com>, <linux-kernel@...r.kernel.org>,
	<hthebaud@...idefr.com>, <matti.j.aaltonen@...ia.com>
Subject: RE: [PATCH] NFC: Driver for Inside Secure MicroRead NFC chip

>> +free_irq:
>> +	free_irq(client->irq, info);
>> +free_buf:
>> +	kfree(info->buf);
>> +free_info:
>> +	kfree(info);
>> +
>> +	dev_info(&client->dev, "Not probed.");
>> +	return ret;
>> +}
>
>When respinning, you could consider using managed devices 
>(devm_*); this error path could completely go then.

Well, to be honest I did't know about that 'feature' :), but now I see it's pretty nice. Will start to use it.

Thanks,
Waldek

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ