linux-kernel - aligning with spaces [was: Re: format fixes]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 20 Mar 2011 14:39:13 +0100
From:	Arne Jansen <lists@...-jansens.de>
To:	Jeffrin Jose <ahiliation@...oo.co.in>
CC:	Greg Kroah-Hartman <gregkh@...e.de>, linux-kernel@...r.kernel.org
Subject: aligning with spaces [was: Re: format fixes]

On 20.03.2011 11:45, Jeffrin Jose wrote:
> I have created a patch with fixes and format
> error by replacing spaces with tabs.

The CodingStyle guide seems to me a big vague on this topic, but
checkpatch.pl has a clear idea of what is right and wrong. But
the formerly present indentation seems to me totally valid.
Use tab to indent to the current indentation level, then continue
with spaces for the alignment of broken-up lines. This has a
few advantages. One of them is that the code still looks neat with
a different tab size (of course, no one ever does that). Another is,
that editing is easier if you change the name of the function and
with it the needed alignment for the following lines.
If we really require using tabs as much as possible for aligning, we
should also _only_ use tabs for it and require e.g. 2 tabs for
broken-up lines.
In fact, the example in CodingStyle uses only tabs and does not try
to align the double quotes of the broken-up string with each other.

--Arne

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/