linux-kernel - Re: [V9fs-developer] [PATCH V2] fs/9p: Use updated offset for writing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 20 Mar 2011 12:59:52 -0500
From:	Eric Van Hensbergen <ericvh@...il.com>
To:	"Aneesh Kumar K. V" <aneesh.kumar@...ux.vnet.ibm.com>
Cc:	"M. Mohan Kumar" <mohan@...ibm.com>,
	v9fs-developer@...ts.sourceforge.net,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [V9fs-developer] [PATCH V2] fs/9p: Use updated offset for writing

Yeah, probably a good idea, if we don't make it in time these are
actually fixes so we can bring them in during -rc1.

On Sun, Mar 20, 2011 at 8:56 AM, Aneesh Kumar K. V
<aneesh.kumar@...ux.vnet.ibm.com> wrote:
> On Wed, 16 Mar 2011 21:40:49 +0530, "M. Mohan Kumar" <mohan@...ibm.com> wrote:
>> Use the updated offset given by generic_write_checks. Without this fix,
>> even if a file is opened in O_APPEND mode, data will be written at current
>> file position instead of end of file.
>>
>> Signed-off-by: M. Mohan Kumar <mohan@...ibm.com>
>
> Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@...ux.vnet.ibm.com>
>
> Eric,
>
> I guess this should go in this merge window ?
>
>> ---
>>  fs/9p/vfs_file.c |    7 +++++--
>>  1 files changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c
>> index 6997eb6..ffed558 100644
>> --- a/fs/9p/vfs_file.c
>> +++ b/fs/9p/vfs_file.c
>> @@ -508,9 +508,12 @@ v9fs_file_write(struct file *filp, const char __user * data,
>>       if (!count)
>>               goto out;
>>
>> -     return v9fs_file_write_internal(filp->f_path.dentry->d_inode,
>> +     retval = v9fs_file_write_internal(filp->f_path.dentry->d_inode,
>>                                       filp->private_data,
>> -                                     data, count, offset, 1);
>> +                                     data, count, &origin, 1);
>> +     /* update offset on successful write */
>> +     if (retval > 0)
>> +             *offset = origin;
>>  out:
>>       return retval;
>>  }
>
> ------------------------------------------------------------------------------
> Colocation vs. Managed Hosting
> A question and answer guide to determining the best fit
> for your organization - today and in the future.
> http://p.sf.net/sfu/internap-sfd2d
> _______________________________________________
> V9fs-developer mailing list
> V9fs-developer@...ts.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/v9fs-developer
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/