linux-kernel - Re: [PATCH] leds: leds-regulator.c, fix handling already enabled regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 23 Mar 2011 21:21:10 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Antonio Ospite <ospite@...denti.unina.it>
Cc:	Richard Purdie <rpurdie@...ys.net>,
	Liam Girdwood <lrg@...mlogic.co.uk>,
	Daniel Ribeiro <drwyrm@...il.com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	openezx-devel@...ts.openezx.org
Subject: Re: [PATCH] leds: leds-regulator.c, fix handling already enabled
 regulators

On Wed, Mar 23, 2011 at 10:00:02PM +0100, Antonio Ospite wrote:

> The leds-regulator driver was ignoring the initial status of the
> regulator; this resulted in rdev->use_count incremented up to 2 after
> calling regulator_led_set_value() in the .probe method when a regulator
> was already enabled at insmod time, and this made impossible to ever
> disable the regulator.

Acked-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>

> NOTE: initially I thought about CC-ing stable@...nel.org as well on 
> this, as it is an actual fix, but then I checked that there are 
> currently no users of the driver in mainline linux and I dropped it, is 
> that how it should be?

Even if there's no users in mainline people could well be shipping out
of tree boards using it and could benefit from the code.  OTOH it's not
the most urgent thing ever.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/