linux-kernel - Re: [PATCH 2/4] staging: keucr: smscsi: Includes missing KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 26 Mar 2011 11:51:26 -0700
From:	Joe Perches <joe@...ches.com>
To:	Ralf Thielow <ralf.thielow@...glemail.com>
Cc:	gregkh@...e.de, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] staging: keucr: smscsi: Includes missing KERN_
 facility level to printk().

On Sat, 2011-03-26 at 17:16 +0100, Ralf Thielow wrote:
> Includes missing KERN_ facility level to printk().
[]
> diff --git a/drivers/staging/keucr/smscsi.c b/drivers/staging/keucr/smscsi.c
[]
> @@ -97,7 +97,7 @@ int SM_SCSI_Read_Capacity(struct us_data *us, struct scsi_cmnd *srb)
>  	WORD bl_len;
>  	BYTE buf[8];
>  
> -	printk("SM_SCSI_Read_Capacity\n");
> +	printk(KERN_DEBUG, "SM_SCSI_Read_Capacity\n");

There should not be a comma between KERN_<level> and format.

Compile tested?

> +	printk(KERN_DEBUG, "bl_len = %x\n", bl_len);
> +	printk(KERN_DEBUG, "bl_num = %x\n", bl_num);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/