linux-kernel - Re: [PATCH]arch:x86:kvm:i8254.h Fix typo in kvm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 30 Mar 2011 16:52:31 -0700
From:	"Justin P. Mattock" <justinmattock@...il.com>
To:	Jiri Kosina <jkosina@...e.cz>
CC:	Avi Kivity <avi@...hat.com>, kvm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH]arch:x86:kvm:i8254.h Fix typo in kvm_pit

On 03/30/2011 03:21 PM, Jiri Kosina wrote:
> On Wed, 30 Mar 2011, Avi Kivity wrote:
>
>>>>> The below patch changes base_addresss to base_address.
>>>>> Note: I have grepped for base_addresss and nothing shows up,
>>>>> grepping for base_address gets me lots of output, telling me that
>>>>> this is a typo, but could be wrong.
>>>>>
>>>>> Signed-off-by: Justin P. Mattock<justinmattock@...il.com>
>>>>>
>>>>> ---
>>>>> arch/x86/kvm/i8254.h | 2 +-
>>>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>>>
>>>>> diff --git a/arch/x86/kvm/i8254.h b/arch/x86/kvm/i8254.h
>>>>> index 46d08ca..c2fa48b 100644
>>>>> --- a/arch/x86/kvm/i8254.h
>>>>> +++ b/arch/x86/kvm/i8254.h
>>>>> @@ -33,7 +33,7 @@ struct kvm_kpit_state {
>>>>> };
>>>>>
>>>>> struct kvm_pit {
>>>>> - unsigned long base_addresss;
>>>>> + unsigned long base_address;
>>>>> struct kvm_io_device dev;
>>>>> struct kvm_io_device speaker_dev;
>>>>> struct kvm *kvm;
>>>>
>>>> Why not remove the variable completely?
>>>>
>>>
>>> didnt even think to completely remove the variable(figured it was used
>>> somewhere).I will look at that and resend with removal of the variable for
>>> you..
>>
>> Well if it was used, you ought to have changed all of the users, no?
>
> I am afraid Justin is not trying to compile-test his patches (I got this
> suspicion after last patchset trying to remove all the includes of
> version.h).
>


I do remember to do that, but I will be honest there are ones that I 
totally forgot, then remembered after sending out the patch(I admit it I 
am guilty of that)

Think having a checklist is the best thing to follow when doing a patch
(telling yourself "yeah Ill remember to do that", never is the best way.

Justin P. Mattock
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/