linux-kernel - Re: [PATCH 0/4] use BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 31 Mar 2011 11:14:26 +0530
From:	"Koul, Vinod" <vinod.koul@...el.com>
To:	Coly Li <bosong.ly@...bao.com>
Cc:	linux-kernel@...r.kernel.org, Greg KH <gregkh@...e.de>,
	Yong Zhang <yong.zhang0@...il.com>,
	Wang Cong <xiyou.wangcong@...il.com>,
	Dan <dan.j.williams@...el.com>
Subject: Re: [PATCH 0/4] use BUG_ON correctly, v4

On Sun, 2011-03-27 at 01:26 +0800, Coly Li wrote:
> Most of BUG_ON() implementations use unlikely() internally for better
> branch prediction results. The following method to use BUG_ON() with
> an explicit unlikely() doesn't make things better and is unwelcome:
> 	BUG_ON(unlikely(condition));
> Source code should use BUG_ON() just with condition code.
> 
> For arch implementation of BUG_ON(), there are feed backs for v2 patch
> set from MIPS and PowerPC developers than neither explicit no implicit
> unlikely() does help anything.
> 
> Therefore using unlikely() explicit with BUG_ON() is always a bug. This
> patch set removes all incorrect BUG_ON() usage.
> 
> Patch "Staging: wl_cfg80211.c: use BUG_ON correctly" is merged into
> upstream (commit d7ddd169), no longer in v4 patch set. For v4 
> patch set, proper maintainers are added into Cc list by the help of
> scripts/get_maintainer.pl.
> 
> Cc: Greg KH <gregkh@...e.de>
> Cc: Yong Zhang <yong.zhang0@...il.com>
> Cc: Wang Cong <xiyou.wangcong@...il.com>
> Signed-off-by: Coly Li <bosong.ly@...bao.com>
> ---
>  drivers/dma/iop-adma.c    |    6 +++---
>  drivers/dma/mv_xor.c      |    6 +++---
>  drivers/dma/ppc4xx/adma.c |    8 ++++----
>  drivers/scsi/scsi_lib.c   |    4 ++--
>  4 files changed, 12 insertions(+), 12 deletions(-)
Thanks, Applied first 3 patches. 4th one should go to scsi folks.
It would help if you can split patch series per subsystem.

-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/