linux-kernel - Re: [GIT PULL] Fix common misspellings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 31 Mar 2011 08:29:49 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Lucas De Marchi <lucas.demarchi@...fusion.mobi>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, trivial@...nel.org,
	lucas.de.marchi@...il.com
Subject: Re: [GIT PULL] Fix common misspellings


hi Lucas,

* Lucas De Marchi <lucas.demarchi@...fusion.mobi> wrote:

> 
> Hi Linus,
> 
> Please pull the following fix for common misspellings in kernel code:
> 
> git://git.profusion.mobi/users/lucas/linux-2.6.git for-linus
> 
> I was doing it in a per maintainer basis, but as noted by Ingo, this was not
> working out.
> 
> There's only one big patch that fixes misspellings in
>  * Documentation
>  * Comments
>  * Strings that are used only in printk and the like

I've gone over your changes and noticed one very small thing, you've changed 
copyright strings as well:

- * Copyright (C) 2007 Marvell Internation Ltd.
+ * Copyright (C) 2007 Marvell International Ltd.
- * Copyright (C) 2007 Marvell Internation Ltd.
+ * Copyright (C) 2007 Marvell International Ltd.
- * Copyright (C) 2007 Marvell Internation Ltd.
+ * Copyright (C) 2007 Marvell International Ltd.
- * Copyright (C) 2007-2008 Marvell Internation Ltd.
+ * Copyright (C) 2007-2008 Marvell International Ltd.
- * Copyright (C) 2007 Marvell Internation Ltd.
+ * Copyright (C) 2007 Marvell International Ltd.
- * Copyright (C) 2007 Marvell Internation Ltd.
+ * Copyright (C) 2007 Marvell International Ltd.
- * Copyright (C) 2007 Marvell Internation Ltd.
+ * Copyright (C) 2007 Marvell International Ltd.
- * Copyright (c) 2002 The Regents of the Unviersity of Michigan
+ * Copyright (c) 2002 The Regents of the University of Michigan

While all the fixes are correct, i'd advise against changing copyright notices 
without the SOB of the authors. The s/Unviersity/University fix would be ok i 
guess because it's a very clear typo, but the Marvell one is borderline (while 
it too is probably a typo) i think it needs a signoff from those who put the 
copyright notices there in that form.

You could leave out those bits from the patch as well.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/