linux-kernel - Re: [PATCH,RFC] perf: panic due to inclied cpu context task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 31 Mar 2011 15:28:15 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Jiri Olsa <jolsa@...hat.com>, Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Subject: Re: [PATCH,RFC] perf: panic due to inclied cpu context task_ctx
	value

On 03/30, Peter Zijlstra wrote:
>
> -atomic_t perf_sched_events __read_mostly;
> +atomic_t perf_sched_events_in __read_mostly;
> +atomic_t perf_sched_events_out __read_mostly;
>  static DEFINE_PER_CPU(atomic_t, perf_cgroup_events);
>
> +static void perf_sched_events_inc(void)
> +{
> +	jump_label_inc(&perf_sched_events_out);
> +	jump_label_inc(&perf_sched_events_in);
> +}
> +
> +static void perf_sched_events_dec(void)
> +{
> +	jump_label_dec(&perf_sched_events_in);
> +	JUMP_LABEL(&perf_sched_events_in, no_sync);
> +	synchronize_sched();
> +no_sync:
> +	jump_label_dec(&perf_sched_events_out);
> +}

OK, synchronize_sched() can't work. How about

	static int force_perf_event_task_sched_out(void *unused)
	{
		struct task_struct *curr = current;

		__perf_event_task_sched_out(curr, task_rq(curr)->idle);

		return 0;
	}

	void synchronize_perf_event_task_sched_out(void)
	{
		stop_machine(force_perf_event_task_sched_out, NULL,
				cpu_possible_mask);
	}

instead?

	- stop_machine(cpu_possible_mask) ensures that each cpu
	  does the context switch and calls _sched_out

	- force_perf_event_task_sched_out() is only needed because
	  the migration thread can have the counters too.

Note, I am not sure this is the best solution. Just in case we don't
find something better.

In any case, do you think this can work or I missed something again?

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/