linux-kernel - Re: [PATCH] add support for Lenovo tablet ID (0xE6)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 31 Mar 2011 12:58:57 -0500
From:	Chris Bagwell <chris@...bagwell.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Manoj Iyer <manoj.iyer@...onical.com>,
	linux-kernel@...r.kernel.org, pingc@...om.com
Subject: Re: [PATCH] add support for Lenovo tablet ID (0xE6)

On Thu, Mar 31, 2011 at 12:43 PM, Dmitry Torokhov
<dmitry.torokhov@...il.com> wrote:
> On Thu, Mar 31, 2011 at 12:20:52PM -0500, Manoj Iyer wrote:
>> Signed-off-by: Manoj Iyer <manoj.iyer@...onical.com>
>> ---
>>  drivers/input/tablet/wacom_wac.c |    3 +++
>>  1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c
>> index 5597637..f751224 100644
>> --- a/drivers/input/tablet/wacom_wac.c
>> +++ b/drivers/input/tablet/wacom_wac.c
>> @@ -1364,6 +1364,8 @@ static const struct wacom_features wacom_features_0xE2 =
>>       { "Wacom ISDv4 E2",       WACOM_PKGLEN_TPC2FG,    26202, 16325,  255,  0, TABLETPC2FG };
>>  static const struct wacom_features wacom_features_0xE3 =
>>       { "Wacom ISDv4 E3",       WACOM_PKGLEN_TPC2FG,    26202, 16325,  255,  0, TABLETPC2FG };
>> +static const struct wacom_features wacom_features_0xE6 =
>> +     { "ISD-V4",               WACOM_PKGLEN_TPC2FG,    27760, 15694,  255,  0, TABLETPC2FG };
>
> Manoj, shouldn't we call it "Wacom ISDv4 E6" to be consistent?

I think its best to rename to be consistent with others in series.

>
> Ping, is resolution the same as with other "ISDv4"s?

My guess is yes.

Note: There is a patch from Ping that you recently accepted but I do
not see on a branch yet (maybe I'm looking in wrong place).  In it,
Ping replaces all resolution values with #defines and they are metric
based (aligns with synaptics) instead of these based on inches.

This patch is on version before that patch.

When convering over, it looks like value of 100/WACOM_INTUOS_RES is
the value to use here.

>
> Thanks,
>
> --
> Dmitry
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/