lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 31 Mar 2011 23:43:27 -0700
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Florian Mickler <florian@...kler.org>,
	linux-kernel@...r.kernel.org, kurup_avinash@...oo.com,
	maciej.rutecki@...il.com, rjw@...k.pl, sedat.dilek@...il.com,
	stable@...nel.org, #.34+@...atten.dmk.lab
Subject: Re: [PATCH v2] x86, ioapic: Skip looking for ioapic overrides when ioapics are not present

Ingo Molnar <mingo@...e.hu> writes:

> * Florian Mickler <florian@...kler.org> wrote:
>
>> --- a/arch/x86/kernel/apic/io_apic.c
>> +++ b/arch/x86/kernel/apic/io_apic.c
>> @@ -3789,6 +3789,10 @@ int acpi_get_override_irq(u32 gsi, int *trigger, int *polarity)
>>  {
>>  	int ioapic, pin, idx;
>>  
>> +#ifdef CONFIG_ACPI
>> +	if (acpi_irq_model != ACPI_IRQ_MODEL_IOAPIC)
>> +		return -1;
>> +#endif
>
> That #ifdef is very ugly. Please introduce a suitable helper function in 
> arch/x86/include/asm/acpi.h - acpi_irq_ioapic_model() or so, which could be 
> used like this:
>
> 	if (!acpi_irq_ioapic_model())
> 		return -1;
>
> And would be defined in the !CONFIG_ACPI case as well.

If you want clean this function needs to be moved out of io_apic.c where
into acpi.c where it belongs.  I don't know that going that far to fix
an annoying warning message is warranted.  The function should only have
callers when acpi is compiled so it is safe to make the entire function
#ifdef ACPI. 

A silly helper in acpi.h is definitely the wrong way to go.

Eric

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux - Powered by OpenVZ