linux-kernel - Re: linux-next: Tree for April 4 [BROKEN thinkpad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 Apr 2011 14:00:36 +0100
From:	Matthew Garrett <mjg@...hat.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>, sedat.dilek@...il.com,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	platform-driver-x86 <platform-driver-x86@...r.kernel.org>,
	ibm-acpi@....eng.br
Subject: Re: linux-next: Tree for April 4 [BROKEN thinkpad_acpi]

On Mon, Apr 04, 2011 at 05:49:29AM -0700, Joe Perches wrote:

> It's vdbg_printk no_printk verification.
> 
> #ifdef CONFIG_THINKPAD_ACPI_DEBUG
> #define vdbg_printk dbg_printk
> static const char *str_supported(int is_supported);
> #else
> #define vdbg_printk(a_dbg_level, format, arg...)	\
> 	no_printk(format, ##arg)
> #endif
> 
> Two ways to handle this.
> 
> 1: add
> static inline const char *str_supported(int is_supported) { return ""; }
> to the #else
> 
> 2: Remove no_printk verification and return it to do {} while (0)
> 
> Do you have a preference?

I don't. Henrique?

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/