linux-kernel - Re: [PATCH 07/07] Replaced printk with pr_info in hv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 Apr 2011 22:00:45 -0700
From:	Greg KH <greg@...ah.com>
To:	Hank Janssen <hjanssen@...rosoft.com>
Cc:	haiyangz@...rosoft.com, gregkh@...e.de,
	linux-kernel@...r.kernel.org, devel@...uxdriverproject.org,
	virtualization@...ts.osdl.org,
	"K. Y. Srinivasan" <kys@...rosoft.com>
Subject: Re: [PATCH 07/07] Replaced printk with pr_info in hv_timesource

On Tue, Mar 29, 2011 at 01:58:50PM -0700, Hank Janssen wrote:
> Replaced printk in hv_timesource with pr_ calls
> 
> Signed-off-by: Hank Janssen <hjanssen@...rosoft.com>
> Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>
> Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com>
> 
> ---
>  drivers/staging/hv/hv_timesource.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/hv/hv_timesource.c b/drivers/staging/hv/hv_timesource.c
> index a7ee533..0efb049 100644
> --- a/drivers/staging/hv/hv_timesource.c
> +++ b/drivers/staging/hv/hv_timesource.c
> @@ -20,6 +20,7 @@
>   * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
>   *
>   */
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>  
>  #include <linux/version.h>
>  #include <linux/clocksource.h>
> @@ -91,7 +92,7 @@ static int __init init_hv_clocksource(void)
>  	if (!dmi_check_system(hv_timesource_dmi_table))
>  		return -ENODEV;
>  
> -	printk(KERN_INFO "Registering HyperV clock source\n");
> +	pr_info("Registering HyperV clock source\n");

Why is this line even needed at all?  Please remove it in future
patches.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/