linux-kernel - Re: [PATCH v2] trivial: make comment about vs{n,cn,}printf more understandable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 6 Apr 2011 07:37:34 -0700 (PDT)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org, Steven Rostedt <rostedt@...dmis.org>,
	Will Schmidt <will_schmidt@...t.ibm.com>,
	Randy Dunlap <rdunlap@...otime.net>,
	Milton Miller <miltonm@....com>
Subject: Re: [PATCH v2] trivial: make comment about vs{n,cn,}printf more
 understandable

On Wed, 6 Apr 2011, Uwe Kleine-König wrote:

> Hello Jiri,
> 
> On Wed, Nov 24, 2010 at 08:10:33PM +0100, Uwe Kleine-König wrote:
> > "You probably want ... instead." sounds like a recommendation better
> > not to use the v... functions.
> you didn't take this patch. Did you skip it on purpose?

Hi,

I don't see it in the trivial 'todo' queue. Either I though someone else 
is taking it, or I just missed it. Could you please re-bounce it to 
trivial@...nel.org, and I will apply it?

Thanks.

> 
> Best regards
> Uwe
> 
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> > ---
> > Hello,
> > 
> > this is Milton's alternative suggestion plus an added "using".
> > 
> > Thanks
> > Uwe
> > 
> >  lib/vsprintf.c |    9 +++------
> >  1 files changed, 3 insertions(+), 6 deletions(-)
> > 
> > diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> > index c150d3d..6c46e0f 100644
> > --- a/lib/vsprintf.c
> > +++ b/lib/vsprintf.c
> > @@ -1279,8 +1279,7 @@ qualifier:
> >   * return is greater than or equal to @size, the resulting
> >   * string is truncated.
> >   *
> > - * Call this function if you are already dealing with a va_list.
> > - * You probably want snprintf() instead.
> > + * If you're not already dealing with a va_list consider using snprintf().
> >   */
> >  int vsnprintf(char *buf, size_t size, const char *fmt, va_list args)
> >  {
> > @@ -1454,8 +1453,7 @@ EXPORT_SYMBOL(vsnprintf);
> >   * the @buf not including the trailing '\0'. If @size is <= 0 the function
> >   * returns 0.
> >   *
> > - * Call this function if you are already dealing with a va_list.
> > - * You probably want scnprintf() instead.
> > + * If you're not already dealing with a va_list consider using scnprintf().
> >   *
> >   * See the vsnprintf() documentation for format string extensions over C99.
> >   */
> > @@ -1534,8 +1532,7 @@ EXPORT_SYMBOL(scnprintf);
> >   * into @buf. Use vsnprintf() or vscnprintf() in order to avoid
> >   * buffer overflows.
> >   *
> > - * Call this function if you are already dealing with a va_list.
> > - * You probably want sprintf() instead.
> > + * If you're not already dealing with a va_list consider using sprintf().
> >   *
> >   * See the vsnprintf() documentation for format string extensions over C99.
> >   */
> > -- 
> > 1.7.2.3
> > 
> > 
> 
> -- 
> Pengutronix e.K.                           | Uwe Kleine-König            |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> 

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/