lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 9 Apr 2011 16:41:30 +0400 From: Vasiliy Kulikov <segoon@...nwall.com> To: linux-kernel@...r.kernel.org Cc: Arnd Bergmann <arnd@...db.de>, Frederic Weisbecker <fweisbec@...il.com> Subject: [PATCH] char: genrtc: fix infoleak to userspace struct pll is copied to userspace. It is filled in "multiplexing" function get_rtc_pll(). At least one implementator, q40_get_rtc_pll(), doesn't fill .pll_ctrl field. It's hard to understand whether either the caller or the callee must zero the unused struct fields, however, on another ioctl commands the caller already zeroes the structure. So, let's the caller use memset(). Signed-off-by: Vasiliy Kulikov <segoon@...nwall.com> --- drivers/char/genrtc.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/char/genrtc.c b/drivers/char/genrtc.c index f773a9d..65cd683 100644 --- a/drivers/char/genrtc.c +++ b/drivers/char/genrtc.c @@ -273,6 +273,7 @@ static int gen_rtc_ioctl(struct file *file, switch (cmd) { case RTC_PLL_GET: + memset(&pll, 0, sizeof(pll)); if (get_rtc_pll(&pll)) return -EINVAL; else -- 1.7.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists