lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 10 Apr 2011 15:12:58 -0500 From: Steve Wise <swise@...ngridcomputing.com> To: roel <roel.kluin@...il.com> CC: Steve Wise <swise@...lsio.com>, linux-rdma@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] RDMA/cxgb4: missing parentheses Acked-by: Steve Wise <swise@...ngridcomputing.com> On 4/10/2011 2:47 PM, roel wrote: > Parens are missing: '|' has a higher presedence than '?'. > > Signed-off-by: Roel Kluin<roel.kluin@...il.com> > --- > drivers/infiniband/hw/cxgb4/qp.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/drivers/infiniband/hw/cxgb4/qp.c > index 70a5a3c..80cab20 100644 > --- a/drivers/infiniband/hw/cxgb4/qp.c > +++ b/drivers/infiniband/hw/cxgb4/qp.c > @@ -214,7 +214,7 @@ static int create_qp(struct c4iw_rdev *rdev, struct t4_wq *wq, > V_FW_RI_RES_WR_HOSTFCMODE(0) | /* no host cidx updates */ > V_FW_RI_RES_WR_CPRIO(0) | /* don't keep in chip cache */ > V_FW_RI_RES_WR_PCIECHN(0) | /* set by uP at ri_init time */ > - t4_sq_onchip(&wq->sq) ? F_FW_RI_RES_WR_ONCHIP : 0 | > + (t4_sq_onchip(&wq->sq) ? F_FW_RI_RES_WR_ONCHIP : 0) | > V_FW_RI_RES_WR_IQID(scq->cqid)); > res->u.sqrq.dcaen_to_eqsize = cpu_to_be32( > V_FW_RI_RES_WR_DCAEN(0) | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists