linux-kernel - Re: [PATCH 1/2] x86/amd-iommu: Add extended feature detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Apr 2011 15:11:44 -0000
From:	"Rolf Eike Beer" <eike-kernel@...tec.de>
To:	"Joerg Roedel" <joerg.roedel@....com>
Cc:	iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org, "Joerg Roedel" <joerg.roedel@....com>
Subject: Re: [PATCH 1/2] x86/amd-iommu: Add extended feature detection

> This patch adds detection of the extended features of an
> AMD IOMMU. The available features are printed to dmesg on
> boot.

> diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c
> index bcf58ea..d609610 100644
> --- a/arch/x86/kernel/amd_iommu.c
> +++ b/arch/x86/kernel/amd_iommu.c
> @@ -29,8 +29,8 @@
>  #include <asm/proto.h>
>  #include <asm/iommu.h>
>  #include <asm/gart.h>
> -#include <asm/amd_iommu_proto.h>
>  #include <asm/amd_iommu_types.h>
> +#include <asm/amd_iommu_proto.h>
>  #include <asm/amd_iommu.h>

That one (and the second place where this happens later) look suspicious.
Do you need that change? Usually those includes tend to be alphabetically
sorted (which you destroy here).

When you _need_ that change that means that you probably use some things
from amd_iommu_types.h in amd_iommu_proto.h without including that header
there (which is a bug in amd_iommu_proto.h and must be fixed there).
Otherwise this change is just noise. So either way this change should not
happen IMHO.

Eike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/