lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Mon, 11 Apr 2011 15:14:33 -0500
From:	Andrei Warkentin <andreiw@...orola.com>
To:	Greg KH <gregkh@...e.de>
Cc:	linux-kernel@...r.kernel.org, hjanssen@...rosoft.com,
	haiyangz@...rosoft.com
Subject: Re: [PATCH] HV SynthHID: Fix compile error.

On Mon, Apr 11, 2011 at 2:27 PM, Greg KH <gregkh@...e.de> wrote:
> On Mon, Apr 11, 2011 at 03:01:32PM -0500, Andrei Warkentin wrote:
>> Missing include for <asm/delay.h>
>>
>> Signed-off-by: Andrei Warkentin <andreiw@...orola.com>
>> ---
>>  drivers/staging/hv/hv_mouse.c |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/staging/hv/hv_mouse.c b/drivers/staging/hv/hv_mouse.c
>> index 50147f8..c5020c0 100644
>> --- a/drivers/staging/hv/hv_mouse.c
>> +++ b/drivers/staging/hv/hv_mouse.c
>> @@ -23,6 +23,7 @@
>>  #include <linux/hiddev.h>
>>  #include <linux/pci.h>
>>  #include <linux/dmi.h>
>> +#include <asm/delay.h>
>
> Never include "<asm/" include files if at all possible.
>

Oops, alright, will do.

> Anyway, this should already be fixed in Linus's tree, right?
>

Sorry no clue, if so, thanks ahead. I was testing something else in
SD/MMC-land and wanted to make sure it compiled cleanly on x86/x64.

A
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists