| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 Apr 2011 11:16:47 +0300 From: Ohad Ben-Cohen <ohad@...ery.com> To: Arnd Bergmann <arnd@...db.de> Cc: mathieu.poirier@...aro.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, lee.jones@...aro.org, patches@...aro.org, linus.walleij@...ricsson.com Subject: Re: [PATCH 1/2] ux500: Adding support for u8500 Hsem functionality V2 On Tue, Apr 12, 2011 at 8:46 PM, Arnd Bergmann <arnd@...db.de> wrote: > When you do that, this can be a single allocation. > > Thinking about it some more, it may actually be worthwhile to still improve > the API here: I think the owner field should be part of the operations structure, > because it is constant. It would also be nice to have a "private" pointer > in struct hwspinlock, so you don't need to wrap it if you don't want to. These are good improvements, part of which I planned to do so too (especially to take out the dev, ops and owner fields into a dedicated structure, and have all the hwspinlock instances, which belong to that block, point at it). By introducing a "private" pointer, and removing the platform-specific wrapping around it, we can also get rid of the 'id' field, and induce it with a simple pointers arithmetic (namely, id = pointer of instance - array base address). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists